[PATCH] D60977: [llvm-profdata] Add overlap command to compute similarity b/w two profile files

Rong Xu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 29 10:41:58 PDT 2019


xur marked 5 inline comments as done.
xur added inline comments.


================
Comment at: llvm/tools/llvm-profdata/llvm-profdata.cpp:212
+  if (Error E = ReaderOrErr.takeError()) {
+    // Skip the empty profiles by returning sliently.
+    instrprof_error IPE = InstrProfError::take(std::move(E));
----------------
davidxl wrote:
> -> silently
> 
> I don't see a return here.
fixed


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60977/new/

https://reviews.llvm.org/D60977





More information about the llvm-commits mailing list