[PATCH] D61070: [libFuzzer] Enable on i386

[Matt Morehouse via Phabricator via llvm-commits]

morehouse added inline comments.


================
Comment at: compiler-rt/lib/fuzzer/CMakeLists.txt:128
+      set(EMULATION_ARGUMENT "")
+    endif()
     set(cxx_${arch}_merge_dir "${CMAKE_CURRENT_BINARY_DIR}/cxx_${arch}_merge.dir")
----------------
metzman wrote:
> morehouse wrote:
> > Why is this argument necessary?
> Without it we get this error: `/usr/bin/ld: Relocatable linking with relocations from format elf32-i386 (/home/user/llvm-build/lib/clang/9.0.0/lib/linux/libclang_rt.fuzzer-i386.a(FuzzerCrossOver.cpp.o)) to format elf64-x86-64 (fuzzer.o) is not supported`
> 
> Interestingly, this has been a problem with libFuzzer before, see [[ https://forum.xda-developers.com/android/software-hacking/llvm-clang-dragontc-future-t3318386/page34 | here ]].
The error sounds like we're trying to mix 32-bit and 64-bit.  So maybe we should address that instead?

I also notice that the documentation for some linkers (gold) say that `-m` is obsolete.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61070/new/

https://reviews.llvm.org/D61070