[PATCH] D60825: [llvm-objcopy] - Check dynamic relocation sections for broken references.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM. I agree that inspecting the dynamic relocations to see if there are any references to symbols is a separate issue. Indeed, it technically also applies to regular relocations, not just dynamic ones. There is a potential performance issue here though, which I think might be a problem if we tried to pass the relocations to do this.



================
Comment at: test/tools/llvm-objcopy/ELF/dynrelocsec-remove-shlink-reference.test:12
+
+## Check we zero out sh_link field and allow producing output with the --allow-broken-links.
+# RUN: llvm-objcopy -R .dynsym --allow-broken-links %t %t2
----------------
Either "with --allow-broken-links" or "with the --allow-broken-links switch"


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60825/new/

https://reviews.llvm.org/D60825