[PATCH] D60383: FileCheck [3/12]: Stricter parsing of @LINE expressions

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/lib/Support/FileCheck.cpp:60
+// Parsing helper function that strips the first character in S and returns it.
+static char next(StringRef &S) {
+  char C = S.front();
----------------
`next` is a very unspecific function name to me, and given this is quite a large file, a slightly more specific name might be clearer, e.g. "popFront" or similar.


================
Comment at: llvm/unittests/Support/FileCheckTest.cpp:100
+public:
+  bool parse_expect(std::string &VarName, std::string &Trailer) {
+    StringRef NameTrailer = StringRef(VarName + Trailer);
----------------
parseExpect?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60383/new/

https://reviews.llvm.org/D60383