[llvm] r359430 - vs integration: Use llvm-lib for librarian

[Russell Gallop via llvm-commits]

Author: russell_gallop
Date: Mon Apr 29 03:10:17 2019
New Revision: 359430

URL: http://llvm.org/viewvc/llvm-project?rev=359430&view=rev
Log:
vs integration: Use llvm-lib for librarian

This uses llvm-lib.exe for the librarian instead of Visual Studio
provided lib.exe. Without this it is not possible to create static
libraries with -flto using the plugin.

Original patch by Steven Noonan

This fixes: PR41147

Differential Revision: https://reviews.llvm.org/D61193

Modified:
    llvm/trunk/tools/msbuild/LLVM.Cpp.Common.props
    llvm/trunk/tools/msbuild/LLVM.Cpp.Common.targets
    llvm/trunk/tools/msbuild/llvm-general.xml

Modified: llvm/trunk/tools/msbuild/LLVM.Cpp.Common.props
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/msbuild/LLVM.Cpp.Common.props?rev=359430&r1=359429&r2=359430&view=diff
==============================================================================
--- llvm/trunk/tools/msbuild/LLVM.Cpp.Common.props (original)
+++ llvm/trunk/tools/msbuild/LLVM.Cpp.Common.props Mon Apr 29 03:10:17 2019
@@ -42,8 +42,10 @@
     <LLVMInstallDir Condition="'$(LLVMInstallDir)' != ''">$(LLVMInstallDir)\</LLVMInstallDir>
     <ClangClExecutable>$(LLVMInstallDir)bin\clang-cl.exe</ClangClExecutable>
     <LldLinkExecutable>$(LLVMInstallDir)bin\lld-link.exe</LldLinkExecutable>
+    <LlvmLibExecutable>$(LLVMInstallDir)bin\llvm-lib.exe</LlvmLibExecutable>
     <UseClangCl>true</UseClangCl>
     <UseLldLink>true</UseLldLink>
+    <UseLlvmLib>true</UseLlvmLib>
   </PropertyGroup>
 
   <Import Project="$(VCTargetsPath)\Microsoft.Cpp.WindowsSDK.props" Condition="Exists('$(VCTargetsPath)\Microsoft.Cpp.WindowsSDK.props')"/>

Modified: llvm/trunk/tools/msbuild/LLVM.Cpp.Common.targets
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/msbuild/LLVM.Cpp.Common.targets?rev=359430&r1=359429&r2=359430&view=diff
==============================================================================
--- llvm/trunk/tools/msbuild/LLVM.Cpp.Common.targets (original)
+++ llvm/trunk/tools/msbuild/LLVM.Cpp.Common.targets Mon Apr 29 03:10:17 2019
@@ -9,6 +9,7 @@
          that the user may have overridden in the UI. -->
     <CLToolExe Condition="$(UseClangCl)">$(ClangClExecutable)</CLToolExe>
     <LinkToolExe Condition="$(UseLldLink)">$(LldLinkExecutable)</LinkToolExe>
+    <LIBToolExe Condition="$(UseLlvmLib)">$(LlvmLibExecutable)</LIBToolExe>
   </PropertyGroup>
 
   <ItemGroup>

Modified: llvm/trunk/tools/msbuild/llvm-general.xml
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/msbuild/llvm-general.xml?rev=359430&r1=359429&r2=359430&view=diff
==============================================================================
--- llvm/trunk/tools/msbuild/llvm-general.xml (original)
+++ llvm/trunk/tools/msbuild/llvm-general.xml Mon Apr 29 03:10:17 2019
@@ -52,4 +52,25 @@
                   Category="General">
   </StringProperty>
 
+
+  <BoolProperty Name="UseLlvmLib"
+                DisplayName="Use llvm-lib"
+                Description="Use llvm-lib for managing libraries.  If this option is disabled, the Microsoft librarian (lib.exe) will be used instead."
+                Category="General"
+                Default="true">
+  </BoolProperty>
+  <StringProperty Name="LlvmLibExecutable"
+                  DisplayName="llvm-lib Executable"
+                  Description="Specifies the path to llvm-lib.exe."
+                  Category="General"
+                  Default="$(LLVMInstallDir)bin\llvm-lib.exe"
+                  Subtype="file">
+  </StringProperty>
+
+  <StringProperty Name="LlvmLibAdditionalOptions"
+                  DisplayName="Additional Librarian Options"
+                  Description="Additional options to pass to llvm-lib.  This is essentially the same as General > Librarian > Command Line > Additional Options, except that it is safe to put options here that will be rejected by lib.exe in case you switch toolchains back and forth."
+                  Category="General">
+  </StringProperty>
+
 </Rule>