[PATCH] D61201: [LLD][ELF] Full support for -n (--nmagic) and -N (--omagic)

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: test/ELF/aarch64-script-nmagic.s:1
+// REQUIRES: aarch64
+// RUN: llvm-mc -filetype=obj -triple=aarch64-linux-gnu %s -o %t.o
----------------
Can it be not AArch64 specific test, but generic, i.e. x86?


================
Comment at: test/ELF/aarch64-script-nmagic.s:21
+// RUN: ld.lld %t.o -o %t2.so --shared --hash-style=sysv -n --script %t.script
+// RUN: llvm-readobj --program-headers %t2.so
+
----------------
This like does not have any `FileCheck`.


================
Comment at: test/ELF/aarch64-script-nmagic.s:31
+        .type foo, %function
+foo:    ret
+
----------------
Should this test live in the `linkerscript` folder?

Looks like this place could shorter, like:

```
.text
  ret
```

If then perhaps this test should be `.test`, not `.s`,
like we often do for linker script tests.




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61201/new/

https://reviews.llvm.org/D61201