[PATCH] D61184: [Salvage] Change salvage debug info implementation to use new DW_OP_LLVM_convert where needed

Mon Apr 29 01:39:26 PDT 2019

markus added a comment.

In D61184#1481992 <https://reviews.llvm.org/D61184#1481992>, @markus wrote:

> In D61184#1480359 <https://reviews.llvm.org/D61184#1480359>, @markus wrote:
>
> > A bit prettier would be to introduce a `DW_OP_LLVM_reinterpret` op to do that job.
>
>
> I am preparing a patch for that right now. Regardless of this review it should make the existing `DW_OP_LLVM_convert` stuff a bit cleaner.

Actually forget all I said about `DW_OP_reinterpret`, it turns out that I did not read the spec properly and did not pay attention to the last sentence saying that: `The type of the operand and result type must have the same size in bits`.

So clearly it cannot be used like I suggested.

What I said about using two `DW_OP_LLVM_convert` in sequence still holds though.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61184/new/

https://reviews.llvm.org/D61184