[PATCH] D61241: [DWARF] Fix dump of local/foreign TU lists in .debug_names

[Pavel Labath via Phabricator via llvm-commits]

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

Looks good to me. Thanks for fixing this.



================
Comment at: test/tools/llvm-dwarfdump/X86/debug-names-many-tu.s:75
+	.byte	1                       # Abbrev [1] DW_TAG_compile_unit
+.Lcu_end0:
+
----------------
MaskRay wrote:
> Question: should I add an end-of-mark (.byte 0) here?
I believe it is not necessary, as your abbreviation for the compile unit DIE says `DW_CHILDREN_no`. The same goes for the other question.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61241/new/

https://reviews.llvm.org/D61241