[PATCH] D59431: [DebugInfo] Terminate more kinds of location-list ranges at the end of basic blocks

[David Stenberg via Phabricator via llvm-commits]

dstenb added inline comments.


================
Comment at: lib/CodeGen/AsmPrinter/DbgEntityHistoryCalculator.cpp:380
+            EntryIndex ClobIdx = DbgValues.startClobber(Pair.first, MBB.back());
+            DbgValues.getEntry(Pair.first, Idx).endEntry(ClobIdx);
+            IdxesToRemove.push_back(Idx);
----------------
dstenb wrote:
> I think you can use `Ent` instead of `DbgValues.getEntry(Pair.first, Idx)` here?
Oh, no. Sorry. As we may add an entry to the vector when creating the clobbering entry, `Ent` may be stale.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59431/new/

https://reviews.llvm.org/D59431