[PATCH] D61055: [LoopSimplifyCFG] Suppress expensive DomTree verification in LoopSimplifyCFG
Dave Green via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Apr 28 23:54:55 PDT 2019
dmgreen added a comment.
> I claim that it's better to make it obvious that these checks are slow, and make developers either guard them with EXPENSIVE_CHECKS or opt-in with Fast.
Do you mean removing the default entirely? To makes it explicit.
Whatever we do in the long run needn't be done here, and making this Fast and behind expensive checks is a definite improvement. (I think Full is still more expensive than necessary, even for an expensive checks build).
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61055/new/
https://reviews.llvm.org/D61055
More information about the llvm-commits
mailing list