[PATCH] D61055: [LoopSimplifyCFG] Suppress expensive DomTree verification in LoopSimplifyCFG

Yevgeny Rouban via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 28 20:41:56 PDT 2019


yrouban added a comment.

In D61055#1481863 <https://reviews.llvm.org/D61055#1481863>, @kuhar wrote:

> It of course depends on exactly location, but we found that Fast is generally not quick enough to be run during a typical loop pass (on large files, or loopy code from non-clang frontends). I claim that it's better to make it obvious that these checks are slow, and make developers either guard them with `EXEPNSIVE_CHECKS` or opt-in with Fast.


Does it mean that you lgtm if I will remove the else part of the change (дштуы 604-606).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61055/new/

https://reviews.llvm.org/D61055





More information about the llvm-commits mailing list