[PATCH] D61241: [DWARF] Fix dump of local/foreign TU lists in .debug_names

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 28 08:15:02 PDT 2019


MaskRay marked 2 inline comments as done.
MaskRay added inline comments.


================
Comment at: test/tools/llvm-dwarfdump/X86/debug-names-many-tu.s:75
+	.byte	1                       # Abbrev [1] DW_TAG_compile_unit
+.Lcu_end0:
+
----------------
Question: should I add an end-of-mark (.byte 0) here?


================
Comment at: test/tools/llvm-dwarfdump/X86/debug-names-many-tu.s:88
+	.asciz "A"
+	.byte	0                       # End of mark
+.Ltu_end0:
----------------
Question: is the end-of-mark (`.byte 0`) necessary?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61241/new/

https://reviews.llvm.org/D61241





More information about the llvm-commits mailing list