[PATCH] D61150: [SimplifyCFG] NFC, update Switch tests to HEAD so I can see if my changes change anything

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: test/Transforms/SimplifyCFG/X86/lit.local.cfg:1
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
 if not 'X86' in config.root.targets:
----------------
jmolloy wrote:
> Revert hunk in this file.
This one is not done yet.


================
Comment at: test/Transforms/SimplifyCFG/X86/switch_to_lookup_table.ll:375
 ; CHECK: large
 ; CHECK-NOT: switch i32
 define i32 @large(i32 %x) {
----------------
A leftover CHECK.


================
Comment at: test/Transforms/SimplifyCFG/X86/switch_to_lookup_table.ll:1589
 ; CHECK:       cleanup4:
 ; CHECK-NEXT:  br label %cleanup4
 
----------------
Leftover CHECK.


================
Comment at: test/Transforms/SimplifyCFG/X86/switch_to_lookup_table.ll:1676
 
 ; CHECK-LABEL: @wineh_test(
 ; CHECK: entry:
----------------
Leftover CHECKs.


================
Comment at: test/Transforms/SimplifyCFG/switch_create-custom-dl.ll:58
+  ret void
 ; DL:  %magicptr = ptrtoint i32* %V to i32
 ; DL:  switch i32 %magicptr, label %F [
----------------
It looks like these check lines were added with an incorrect prefix originally and didn't do anything... They can be dropped now that the proper CHECKs are there.


================
Comment at: test/Transforms/SimplifyCFG/switch_create-custom-dl.ll:89
+  ret void
 ; DL:  %magicptr = ptrtoint i32 addrspace(1)* %V to i16
 ; DL:  switch i16 %magicptr, label %F [
----------------
Same here.


================
Comment at: test/Transforms/SimplifyCFG/switch_create-custom-dl.ll:752
 ; Form a switch when and'ing a negated power of two
 ; CHECK-LABEL: define void @test19
 ; CHECK: switch i32 %arg, label %else [
----------------
Leftover CHECKs.


================
Comment at: test/Transforms/SimplifyCFG/switch_create-custom-dl.ll:816
 ; Form a switch when or'ing a power of two
 ; CHECK-LABEL: define void @test21
 ; CHECK: i32 32, label %else
----------------
Leftover CHECKS.


================
Comment at: test/Transforms/SimplifyCFG/switch_create-custom-dl.ll:848
 ; Since %cmp1 is always false, a switch is never formed
 ; CHECK-LABEL: define void @test22
 ; CHECK-NOT: switch
----------------
Leftover CHECKS.


================
Comment at: test/Transforms/SimplifyCFG/switch_create.ll:742
 ; Form a switch when and'ing a negated power of two
 ; CHECK-LABEL: define void @test19
 ; CHECK: switch i32 %arg, label %else [
----------------
Leftover CHECKS. (Also in the rest of this file.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61150/new/

https://reviews.llvm.org/D61150