[PATCH] D60654: Fix UNPREDICTABLE check in EmulateInstructionARM::EmulateADDRegShift

Raphael Isemann via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 27 11:13:39 PDT 2019


This revision was automatically updated to reflect the committed changes.
Closed by commit rL359387: Fix UNPREDICTABLE check in EmulateInstructionARM::EmulateADDRegShift (authored by teemperor, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Changed prior to commit:
  https://reviews.llvm.org/D60654?vs=195025&id=196981#toc

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60654/new/

https://reviews.llvm.org/D60654

Files:
  lldb/trunk/source/Plugins/Instruction/ARM/EmulateInstructionARM.cpp


Index: lldb/trunk/source/Plugins/Instruction/ARM/EmulateInstructionARM.cpp
===================================================================
--- lldb/trunk/source/Plugins/Instruction/ARM/EmulateInstructionARM.cpp
+++ lldb/trunk/source/Plugins/Instruction/ARM/EmulateInstructionARM.cpp
@@ -10150,7 +10150,7 @@
       shift_t = DecodeRegShift(Bits32(opcode, 6, 5));
 
       // if d == 15 || n == 15 || m == 15 || s == 15 then UNPREDICTABLE;
-      if ((d == 15) || (m == 15) || (m == 15) || (s == 15))
+      if ((d == 15) || (n == 15) || (m == 15) || (s == 15))
         return false;
       break;
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D60654.196981.patch
Type: text/x-patch
Size: 603 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190427/8b14a218/attachment.bin>


More information about the llvm-commits mailing list