[PATCH] D60897: [SLP] Look-ahead operand reordering heuristic.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:149
+static cl::opt<int> LookAheadMaxDepth(
+    "look-ahead-max-depth", cl::init(2), cl::Hidden,
+    cl::desc("The maximum look-ahead level for cost model matching"));
----------------
"slp-max-look-ahead-depth" might be better?


================
Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:744
+    /// Score for failing to find a decent match.
+    static const int ScoreFail = 0;
+
----------------
These kinds of hard coded costs scare me, especially without any context/description.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60897/new/

https://reviews.llvm.org/D60897