[PATCH] D54815: [ThinLTO] Add summary entries for index-based WPD

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: include/llvm/IR/ModuleSummaryIndex.h:683
+/// initializer array.
+using VirtFuncOffsetPair = std::pair<ValueInfo, uint64_t>;
+/// List of functions referenced by a particular vtable definition.
----------------
Instead of declaring this and `TypeIdOffsetVtablePair` as a pair, would it be better to declare them as structs with appropriately named fields? Seems like it would make the usage code easier to understand.


================
Comment at: lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp:447
+      return splitAndWriteThinLTOBitcode(OS, ThinLinkOS, AARGetter, M);
+    else {
+      // Promote type ids as needed for index-based WPD.
----------------
No else after return


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54815/new/

https://reviews.llvm.org/D54815