[PATCH] D59531: [ELF] Produce multiple PT_NOTE segments as needed

Fri Apr 26 13:45:17 PDT 2019

jakehehrlich added a comment.

The larger alignment isn't being set by mistake there's just an odd note that's being added to linux binaries right now and its causing this sort of headache.

In D59531#1445689 <https://reviews.llvm.org/D59531#1445689>, @peter.smith wrote:

> If I've understood the latest patch right then pcc's original test case will still fail if both notes sections in the example below are 4-byte aligned.
>
>   SECTIONS {
>     . = SIZEOF_HEADERS;
>     .note1 : { *(.note1) }
>     . = 0x10000;
>     .note2 : { *(.note2) }
>   }
>
>
> If this is still the intention to support this case then it would be good to add a test case.

It would fall back to the original behavior for this case which is acceptable for this patch.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59531/new/

https://reviews.llvm.org/D59531