[PATCH] D61203: [compiler-rt] Fix cmake warnings

Wink Saville via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 26 11:57:12 PDT 2019


winksaville added a comment.

In D61203#1480771 <https://reviews.llvm.org/D61203#1480771>, @eugenis wrote:

> I think  __hwasan_tls should be defined if !SANITIZER_ANDROID, without the other condition.


Ok, should I do that here or a different change?

Looking at the code it seems we should remove HWASAN_WITH_INTERCEPTORS in hwasan_linux.cpp
and just use SANITIZER_ANDROID, your thoughts?

What have I done wrong to cause the 8-10 FAILED's tests?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61203/new/

https://reviews.llvm.org/D61203





More information about the llvm-commits mailing list