[PATCH] D61164: [X86] If PreprocessISelDAG reorders a load before a call, make sure we remove dead nodes from the graph

Nirav Dave via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 26 11:43:29 PDT 2019


niravd added a comment.

I was thinking things pending from the folding optimization in getNode, but I missed that it was the target specific one so it should be fine. That said, I still think it's better to do it unconditionally so it'll be pruned by default with the future additio of Listener-based pruning if that proves too expensive.

In D61164#1480551 <https://reviews.llvm.org/D61164#1480551>, @craig.topper wrote:

> By AND construction, I assume you're referring to turning X86ISD::AND into ISD::AND? What's wrong with that code? It's already removing the node it left dead. Or is there a CSE issue?





CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61164/new/

https://reviews.llvm.org/D61164





More information about the llvm-commits mailing list