[PATCH] D61070: [libFuzzer] Enable on i386

[Matt Morehouse via Phabricator via llvm-commits]

morehouse added inline comments.


================
Comment at: compiler-rt/lib/fuzzer/CMakeLists.txt:128
+      set(EMULATION_ARGUMENT "")
+    endif()
     set(cxx_${arch}_merge_dir "${CMAKE_CURRENT_BINARY_DIR}/cxx_${arch}_merge.dir")
----------------
Why is this argument necessary?


================
Comment at: compiler-rt/test/fuzzer/dataflow.test:2
 # Tests the data flow tracer.
-REQUIRES: linux
-UNSUPPORTED: aarch64
+REQUIRES: linux, x86_64
 
----------------
Any idea why this fails on x86?


================
Comment at: compiler-rt/test/fuzzer/only-some-bytes.test:2
 # Tests the data flow tracer.
-REQUIRES: linux
-UNSUPPORTED: aarch64
+REQUIRES: linux, x86_64
 
----------------
Any idea why this doesn't work for x86?


================
Comment at: compiler-rt/test/fuzzer/trace-malloc-threaded.test:4
 // FIXME: Disabled on Windows because of a crash (possibly related to above).
-UNSUPPORTED: darwin, aarch64, windows
+UNSUPPORTED: darwin, aarch64, windows, i386
 
----------------
Any idea why this doesn't work for x86?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61070/new/

https://reviews.llvm.org/D61070