[PATCH] D61193: vs integration: Use llvm-lib for librarian

[Steven Noonan via Phabricator via llvm-commits]

tycho accepted this revision.
tycho added a comment.
This revision is now accepted and ready to land.

LGTM.

Also this maybe an independent change, but:

One thing I ran into when running with this change locally was that `llvm-lib.exe` didn't like the `/LTCG` argument (IIRC it caused a fatal error and `llvm-lib.exe` refused to continue). This also affected `lld-link.exe`. I notice that `LLVM.Cpp.Common.targets` has a big list of options at the bottom that get automatically turned off for compatibility with the LLVM/clang-cl toolchain. Maybe we should add some for `llvm-lib.exe` and `lld-link.exe` to drop the `/LTCG` arguments? Or maybe remap `/LTCG` -> `-flto=thin` under the hood where relevant, or something.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61193/new/

https://reviews.llvm.org/D61193