[PATCH] D61184: [Salvage] Change salvage debug info implementation to use new DW_OP_LLVM_convert where needed

[David Stenberg via Phabricator via llvm-commits]

dstenb added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/Local.cpp:1677
+
+    if (isa<TruncInst>(&I) || isa<ZExtInst>(&I) || isa<SExtInst>(&I)) {
+      unsigned TypeBitSize = Type->getScalarSizeInBits();
----------------
dstenb wrote:
> There is a early bail-out for `ZExtInst` above:
> 
> ```
>     if (CI->isNoopCast(DL) || isa<ZExtInst>(&I))
>       return SrcDIExpr;
> ```
> 
> so that condition in this if statement appears to be dead code as it is now.
> 
> I assume that we no longer should bail out for zexts (?).
Also, perhaps this should be inverted to an early exit instead?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61184/new/

https://reviews.llvm.org/D61184