[PATCH] D60372: [gn] Support for building libc++abi

[Nico Weber via Phabricator via llvm-commits]

thakis added inline comments.


================
Comment at: llvm/utils/gn/secondary/libcxxabi/src/BUILD.gn:17
+  # Do not export any symbols from the static library.
+  libcxxabi_hermetic_static_library = false
+}
----------------
phosek wrote:
> thakis wrote:
> > Wouldn't you always want this? What's an example where one would want to statically link c++abi but export its symbols? They only thing I can think of is when linking it into libc++.dylib, which which case we probably want a toggle for that instead?
> > 
> > Why is the default false? Why is this settable?
> I've tried to match the CMake build where this is disabled by default. I agree with your reasoning but I'm not sure whether we want to deviate from the CMake build?
I think it's fine to deviate from CMake where it makes sense.

- there are many examples of things that are options in cmake but not in gn (usually, because noone needed the option in GN yet, but not always)

- there are a few examples where variable defaults are different because cmake's defaults are arguably not optimal for the average case (examples: gn gives you release+asserts by default while cmake gives you debug by default, gn only builds host target by default while cmake builds all of them by default, ...)

So if that's the only reason this is the way it is, I think it's fine to change it if you agree that that makes sense.


Repository:
  rCXXA libc++abi

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60372/new/

https://reviews.llvm.org/D60372