[PATCH] D56151: [DebugInfo] PR40010: Avoid register coalesing altering DBG_VALUE valuations

Fri Apr 26 04:01:07 PDT 2019

jmorse added a comment.

Hi, I've uploaded D61181 <https://reviews.llvm.org/D61181> with a patch that might fix those regressions -- if you happen to have any spare cycles for evaluating it that'd be appreciated.

If that patch doesn't work well though, then we're likely stuck in the tar pit with some unfortunate facts:

- Avoiding debug uses of non-live VRegs would be difficult to fix quickly,
- This patch here would lead to debug regressions if committed,
- Without this patch, disabling placeDbgValues (D58453 <https://reviews.llvm.org/D58453>) and the resulting greater distribution of dbg.values throughout functions would be liable to the failure mode this patch tries to fix.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56151/new/

https://reviews.llvm.org/D56151