[PATCH] D58484: [DO NOT SUBMIT] Add -vs-diagnostics.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

Apologies for the belated response. I'm happy with this patch.



================
Comment at: Common/ErrorHandler.cpp:98
+  std::smatch Match;
+  for (std::regex &Re : Regexes)
+    if (std::regex_search(Msg, Match, Re)) {
----------------
nit: add {}


================
Comment at: ELF/Driver.cpp:761
       Args.hasFlag(OPT_fatal_warnings, OPT_no_fatal_warnings, false);
+  errorHandler().VsDiag = Args.hasArg(OPT_vs_diagnostics);
   ThreadsEnabled = Args.hasFlag(OPT_threads, OPT_no_threads, true);
----------------
The members of this class have the same names of the corresponding options, so `VsDiagnostics`.


================
Comment at: ELF/Options.td:363
+def vs_diagnostics: F<"vs-diagnostics">,
+HelpText<"Changes diagnostic output format to better match Microsoft Visual Studio">;
+
----------------
Please indent just like other definitions.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58484/new/

https://reviews.llvm.org/D58484