[PATCH] D61092: [llvm-strip] Have --discard-all imply --strip-debug

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 26 01:39:26 PDT 2019


grimar added a comment.

I have no more comments, minor nit/suggestion is inline.



================
Comment at: test/tools/llvm-objcopy/ELF/discard-all-debug.test:5
+
+CHECK:     SectionHeaderCount: 8
----------------
I am not sure it is useful to check the number of sections. All you need is to check that `.debug_` sections are gone I think. 
And that is done by `--sections` + `--implicit-check-not=.debug_`


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61092/new/

https://reviews.llvm.org/D61092





More information about the llvm-commits mailing list