[PATCH] D61158: [SimplifyCFG] use fshr instead of shl/lshr/or

[James Molloy via Phabricator via llvm-commits]

jmolloy added a comment.

Hi,

Yes, I also have the same concerns as Roman. If we don't canonicalize to fshr in instcombine, then we shouldn't canonicalize to fshr in simplifycfg. They're both canonicalization passes.

Given the testing burden, if you really want to go down this route I would recommend changing instcombine *first*, from which you can observe the fallout with a large testing base. Then change this code, which triggers in many fewer cases.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61158/new/

https://reviews.llvm.org/D61158