[PATCH] D61137: Fix llvm-objcopy/ELF/preserve-segment-contents test under Python 3.6

Alexander Shaposhnikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 25 20:16:00 PDT 2019


alexshap accepted this revision.
alexshap added a comment.
This revision is now accepted and ready to land.

to me looks good.

Some side notes:

> Strangely, Python 3.7 on Windows under MINGW32 was fine

perhaps because the default encoding for those environments is different

https://stackoverflow.com/questions/20923663/unicodeencodeerror-ascii-codec-cant-encode-character-in-position-0-ordinal/20923915#20923915
https://stackoverflow.com/questions/31917595/how-to-write-a-raw-hex-byte-to-stdout-in-python-3

I would check the other tests as well - if there are any similar places where we write raw bytes in Python


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61137/new/

https://reviews.llvm.org/D61137





More information about the llvm-commits mailing list