[PATCH] D61030: [PassManagerBuilder] Add option for interleaved loops, for loop vectorize.

Hideki Saito via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 25 17:41:59 PDT 2019


hsaito added a comment.

In D61030#1479532 <https://reviews.llvm.org/D61030#1479532>, @asbirlea wrote:

> > You mean, clang setting EnableLoopInterleaving.
>
> Actually I meant `DisableUnrollLoops` in the `PassManagerBuilder`. It's currently always set to false, not based on a flag, and I found a single instance where it's value is changed in clang (see clang patch).
>
> I'm happy to make whatever change needed to clang first, but I don't see what that change is. If you could point me to what I've missed, that would be great!


All I ask is to check whether -fno-unroll-loops and -funroll-loops clang flags affects what the LoopVectorize constructor sees in it's first incoming parameter. Should be easy enough to print that from the constructor to know for sure. If that's done or your confidence level is as high as that, that's all I need. If those flags affects what LoopVectorize gets, I don't want that behavior to change, and I believe that is also your intent.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61030/new/

https://reviews.llvm.org/D61030





More information about the llvm-commits mailing list