[PATCH] D61013: [NFC] BasicBlock: refactor changePhiUses() out of replacePhiUsesWith(), use it

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 25 17:03:33 PDT 2019


craig.topper added inline comments.


================
Comment at: lib/Transforms/Scalar/LoopInterchange.cpp:1284
                                 BasicBlock *NewPred) {
-  for (PHINode &PHI : CurrBlock->phis())
-    PHI.replaceIncomingBlockWith(OldPred, NewPred);
+  CurrBlock->replacePhiUsesWith(OldPred, NewPred);
 }
----------------
Should the callers of updateIncomingBlock just use replacePhiUsesWith directly?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61013/new/

https://reviews.llvm.org/D61013





More information about the llvm-commits mailing list