[PATCH] D61145: [NFC][Sanitizer] Change "return type" of INTERCEPT_FUNCTION to void
Vitaly Buka via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 25 14:15:54 PDT 2019
vitalybuka added inline comments.
================
Comment at: compiler-rt/lib/interception/interception_linux.h:37
+ (::__interception::uptr) & WRAP(func)); \
+ } while (0) // TODO(yln): temporarily make macro void.
----------------
why?
================
Comment at: compiler-rt/lib/msan/msan_interceptors.cc:1247
+ INTERCEPT_FUNCTION(name); \
+ bool same = (& (name) == & WRAP(name)); \
+ if ((!same || !REAL(name))) \
----------------
why you don't want to keep this comparison inside of INTERCEPT_FUNCTION_LINUX_OR_FREEBSD?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61145/new/
https://reviews.llvm.org/D61145
More information about the llvm-commits
mailing list