[PATCH] D60512: [X86][AVX] Combine shuffles extracted from a common vector

Thu Apr 25 12:55:48 PDT 2019

spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM

================
Comment at: test/CodeGen/X86/avx512-shuffles/partial_permute.ll:4411
+; CHECK-NEXT:    vmovapd {{.*#+}} zmm2 = <1,4,u,u,u,u,u,u>
+; CHECK-NEXT:    vpermpd (%rdi), %zmm2, %zmm2
 ; CHECK-NEXT:    vxorpd %xmm3, %xmm3, %xmm3
----------------
RKSimon wrote:
> This is annoying - I'd be happier if the mask in zmm2 was at least reduced to a <1,4> xmm load (or broadcasted) but that's a common issue in a lot of the masks generated in this patch.
Mark this with a TODO and/or file a bug report, so we don't lose track?

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60512/new/

https://reviews.llvm.org/D60512