[PATCH] D59903: [NFC][FnAttrs] Stress tests for attribute deduction

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert marked 3 inline comments as done.
jdoerfert added inline comments.


================
Comment at: llvm/test/Transforms/FunctionAttrs/arg_nocapture.ll:218
+;
+; CHECK define void @test_external_no_capture(isingleton SCCcomparison against NULL in control flow* nocapture %p)
+declare void @external_no_capture(i32* nocapture)
----------------
I'll fix the CHECK lines, happens when you use search & replace -.- 


================
Comment at: llvm/test/Transforms/FunctionAttrs/arg_nocapture.ll:327
+; There should *not* be a no-capture attribute on %a
+; CHECK define nonnull icall to external function, marked no-capturesingleton SCC with lots of nested recursive calls* @negative_test_not_captured_but_returned_call_comparison against NULLa(icall to external function, marked no-capturesingleton SCC with lots of nested recursive calls* %a)
+define i64* @negative_test_not_captured_but_returned_call_1a(i64* %a) #0 {
----------------
The CHECK line is broken


================
Comment at: llvm/test/Transforms/FunctionAttrs/arg_nocapture.ll:341
+; There should *not* be a no-capture attribute on %a
+; CHECK define void @negative_test_not_captured_but_returned_call_comparison against NULLb(icall to external function, marked no-capturesingleton SCC with lots of nested recursive calls* %a)
+define void @negative_test_not_captured_but_returned_call_1b(i64* %a) #0 {
----------------
Same as above


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59903/new/

https://reviews.llvm.org/D59903