[PATCH] D59814: [Testing] Move clangd::Annotations to llvm testing support

[Sam McCall via Phabricator via llvm-commits]

sammccall accepted this revision.
sammccall added inline comments.


================
Comment at: llvm/lib/Testing/Support/Annotations.cpp:94
+                                    const llvm::Annotations::Range &R) {
+  return O << llvm::formatv("[{0}, {1})", R.Begin, R.End);
+}
----------------
You could consider including the stringref in the Range struct just to make it print more nicely.
Not sure of all the implications of this, up to you.


================
Comment at: llvm/unittests/Support/AnnotationsTest.cpp:87
+}
+} // namespace
----------------
you could consider some #ifndef NDEBUG EXPECT_DEATH tests for point() with no/multiple points etc. Up to you.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59814/new/

https://reviews.llvm.org/D59814