[PATCH] D61116: [test-suite] MultiSource/Benchmarks/DOE-ProxyApps-C/RSBench: change *CMAKE* target name only

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri created this revision.
lebedev.ri added reviewers: hfinkel, pavanravikanth.kprk.
Herald added a subscriber: mgorny.
Herald added a project: LLVM.

That benchmark produces a binary named `rsbench`, and creates cmake target with name `rsbench`.
All that is good. But unfortunately, 'rsbench' is a **very** short abbreviation.

In particular, it just so happened that i have a main benchmark with the exact same name:
https://github.com/darktable-org/rawspeed/blob/fd5f06086ff323e0a2bdc1e2234dae6ae4e32532/src/utilities/rsbench/CMakeLists.txt#L1
While i'm not sure if it will be possible to integrate that project into test-suite proper,
i'd like to use it at least for local testing. But that is problematic if there is name clashes.

While i realize that it is plain impossible to avoid clashes in general, i'm hoping this particular situation can be solved,
In particular, the problem is *ONLY* the CMake target name. The binary name does **NOT** matter.
Therefore, how about a change from cmake target name of `rsbench` to `doe-rsbench`,
while ensuring the binary name stays the same?


Repository:
  rT test-suite

https://reviews.llvm.org/D61116

Files:
  MultiSource/Benchmarks/DOE-ProxyApps-C/RSBench/CMakeLists.txt


Index: MultiSource/Benchmarks/DOE-ProxyApps-C/RSBench/CMakeLists.txt
===================================================================
--- MultiSource/Benchmarks/DOE-ProxyApps-C/RSBench/CMakeLists.txt
+++ MultiSource/Benchmarks/DOE-ProxyApps-C/RSBench/CMakeLists.txt
@@ -1,4 +1,6 @@
 list(APPEND LDFLAGS -lm)
 list(APPEND CFLAGS -std=gnu99)
 set(RUN_OPTIONS -s small -l 100000 -p 1000 -w 1000)
-llvm_multisource(rsbench)
+# WARNING: *please* keep the cmake target name as doe-rsbench.
+llvm_multisource(doe-rsbench)
+set_target_properties(doe-rsbench PROPERTIES OUTPUT_NAME "rsbench")


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D61116.196581.patch
Type: text/x-patch
Size: 587 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190425/deacf982/attachment.bin>