[PATCH] D60589: [sanitizer_common] Expose a variadic version of the sanitizer Printf function.

Evgenii Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 24 16:42:35 PDT 2019


eugenis added inline comments.


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_printf.h:12
+
+#include <stdarg.h>
+
----------------
kcc wrote:
> Well, no, that's not any better. 
> We *have* to avoid std headers in most .cc files and absolutely have to avoid them 
> in header files that are included into most .cc files. 
> 
> Sadly, the sanitizer run-time is not your common C++ program :( 
How about we move the include into a separate header, sanitizer_vprintf.h, and never use it anywhere?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60589/new/

https://reviews.llvm.org/D60589





More information about the llvm-commits mailing list