[PATCH] D61095: [AArch64][Windows] Compute function length correctly in unwind tables.

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

Well, I guess there are sort of two potential approaches to emitting it "later".  One, we could emit something like ".word (endfunc-beginfunc)/4+0x10800000", as long as we have some conservative estimate we could use to prove that we don't need to split the unwind data.  The other would be to use a dedicated, relaxable fragment, which could grow to accommodate splitting the unwind data if necessary.  The dedicated fragment is probably a bit more bulletproof, and more consistent with the way we handle relaxation in other contexts, but it would require a lot of refactoring to implement.

I can put a FIXME into ARM64EmitUnwindInfo with the above paragraph, sure.  (I don't think the WinException changes need a FIXME; even if we do fix the assembler side of this issue, there isn't any reason for the unwind table to provide unwind information for jump tables.)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61095/new/

https://reviews.llvm.org/D61095