[lld] r359153 - llvm-cvtres: Make new dupe resource error a bit friendlier
Nico Weber via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 24 16:26:30 PDT 2019
Author: nico
Date: Wed Apr 24 16:26:30 2019
New Revision: 359153
URL: http://llvm.org/viewvc/llvm-project?rev=359153&view=rev
Log:
llvm-cvtres: Make new dupe resource error a bit friendlier
For well-known type IDs, include the name of the type.
To not duplicate the ID->name map, make llvm-readobj call this new
function as well. It has slightly different output, so this also
requires updating a few tests.
Differential Revision: https://reviews.llvm.org/D61086
Modified:
lld/trunk/test/COFF/manifestinput.test
lld/trunk/test/COFF/resource.test
Modified: lld/trunk/test/COFF/manifestinput.test
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/COFF/manifestinput.test?rev=359153&r1=359152&r2=359153&view=diff
==============================================================================
--- lld/trunk/test/COFF/manifestinput.test (original)
+++ lld/trunk/test/COFF/manifestinput.test Wed Apr 24 16:26:30 2019
@@ -14,7 +14,7 @@ TEST_EMBED-DAG: Resources [
TEST_EMBED-NEXT: Total Number of Resources: 1
TEST_EMBED-DAG: Number of String Entries: 0
TEST_EMBED-NEXT: Number of ID Entries: 1
-TEST_EMBED-NEXT: Type: kRT_MANIFEST (ID 24) [
+TEST_EMBED-NEXT: Type: MANIFEST (ID 24) [
TEST_EMBED-NEXT: Table Offset: 0x18
TEST_EMBED-NEXT: Number of String Entries: 0
TEST_EMBED-NEXT: Number of ID Entries: 1
Modified: lld/trunk/test/COFF/resource.test
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/COFF/resource.test?rev=359153&r1=359152&r2=359153&view=diff
==============================================================================
--- lld/trunk/test/COFF/resource.test (original)
+++ lld/trunk/test/COFF/resource.test Wed Apr 24 16:26:30 2019
@@ -17,7 +17,7 @@ RESOURCE_INFO-NEXT: Total Number of Re
RESOURCE_INFO-NEXT: Base Table Address: 0x600
RESOURCE_INFO-DAG: Number of String Entries: 0
RESOURCE_INFO-NEXT: Number of ID Entries: 1
-RESOURCE_INFO-NEXT: Type: kRT_STRING (ID 6) [
+RESOURCE_INFO-NEXT: Type: STRINGTABLE (ID 6) [
RESOURCE_INFO-NEXT: Table Offset: 0x18
RESOURCE_INFO-NEXT: Number of String Entries: 0
RESOURCE_INFO-NEXT: Number of ID Entries: 1
More information about the llvm-commits
mailing list