[PATCH] D61096: posix_spawn should retry upon EINTR

[Jan Korous via Phabricator via llvm-commits]

jkorous accepted this revision.
jkorous added a comment.
This revision is now accepted and ready to land.

Hmm, we have this utility function `RetryAfterSignal()` but it doesn't have `maxRetries`.

http://llvm.org/doxygen/namespacellvm_1_1sys.html#aea8b04d954b2cebd8a26d5d712634312

If you feel like you could make it more generic and use it here.

Anyway, the current form LGTM.



================
Comment at: lib/Support/Unix/Program.inc:257
+                        const_cast<char **>(Envp));
+    } while (Err == EINTR && ++retries < maxRetries);
 
----------------
Nit: shouldn't it be `<=` or `s/retries/tries/`?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61096/new/

https://reviews.llvm.org/D61096