[PATCH] D58801: [Support] Implement is_local_impl with AIX mntctl

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 24 14:55:10 PDT 2019


hubert.reinterpretcast marked an inline comment as done.
hubert.reinterpretcast added inline comments.


================
Comment at: llvm/trunk/unittests/Support/Path.cpp:1495
 
+TEST_F(FileSystemTest, is_local) {
+  bool TestDirectoryIsLocal;
----------------
mstojanovic wrote:
> This test fails if `/tmp` in on an nfs. I believe the original test was removed in rL297260 for the same reason.
This checks that a file and its containing directory are equally local or remote. If you are noticing a failure, then it seems the implementation of the query on your system may be reporting on the mountpoint instead of the mounted filesystem.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58801/new/

https://reviews.llvm.org/D58801





More information about the llvm-commits mailing list