[PATCH] D61091: Enable LoopVectorization by default.

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 24 14:54:36 PDT 2019


chandlerc added inline comments.


================
Comment at: tools/opt/opt.cpp:385-388
+  // Check if option **explicitly** enabled or disabled via
+  // -disable-loop-vectorization=false or -vectorize-loops=false
+  // Both are true by default. The first (-disable-loop-vectorization) is only
+  // used to detect a specific user, because opt disables it unless:
----------------
"specific user" doesn't make sense here to me.

Not sure why it makes sense for `DisableLoopVectorization` to be true by default...

I'm not super worried about the existing behavior of cl::opt flags. Those aren't stable. So I'd suggest picking names and set of such flags that are simple and easy to explain.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61091/new/

https://reviews.llvm.org/D61091





More information about the llvm-commits mailing list