[PATCH] D61028: [DAGCombiner] scale repeated FP divisor by splat factor

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 24 08:36:47 PDT 2019


spatel marked an inline comment as done.
spatel added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:11987
+  if (SDValue CombineRepeatedDivisors = combineRepeatedFPDivisors(N))
+    return CombineRepeatedDivisors;
+
----------------
RKSimon wrote:
> Does this move need to be a separate patch?
Yes, let me change that back. I noticed that potential diff while looking at the other part of this patch, so I thought it would be good to see the 2 changes together, but it should stand independently assuming it makes sense.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61028/new/

https://reviews.llvm.org/D61028





More information about the llvm-commits mailing list