[PATCH] D60617: MSan: handle llvm.lifetime.start intrinsic

[Alexander Potapenko via Phabricator via llvm-commits]

glider marked 2 inline comments as done.
glider added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:1299
+    for (auto Item : LifetimeStartList) {
+      Instruction *InsertAt = InstrumentLifetimeStart ? Item.first : nullptr;
+      instrumentAlloca(*Item.second, InsertAt);
----------------
eugenis wrote:
> What if InstrumentLifetimeStart == false, but there is an alloca with multiple lifetime.start ? It looks like you'll poison it several times in a row.
Fixed this by adding alloca to AllocaSet instead of calling instrumentAlloca(*Item.second, nullptr).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60617/new/

https://reviews.llvm.org/D60617