[PATCH] D60715: [ISEL][X86] Tracking of registers that forward call arguments

Nikola Prica via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 24 05:44:51 PDT 2019


NikolaPrica added inline comments.


================
Comment at: include/llvm/CodeGen/SelectionDAG.h:1633
+    if (I != SDCallSiteInfo.end())
+      return std::move(I->second);
+    return CallSiteInfo();
----------------
lebedev.ri wrote:
> The function is marked as `const`, yet this is a `std::move()`.
> Do you mean to only get the `CallSiteInfo` once?
Too bad I got no warning on that. Thanks for pointing that! 

```
Do you mean to only get the `CallSiteInfo` once?
```
Yes. For now it is used only in that way.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60715/new/

https://reviews.llvm.org/D60715





More information about the llvm-commits mailing list