[PATCH] D58042: [LiveDebugValues] Emit parameter's entry value

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro marked 5 inline comments as done.
djtodoro added inline comments.


================
Comment at: lib/CodeGen/LiveDebugValues.cpp:211
     bool operator<(const VarLoc &Other) const {
-      if (Var == Other.Var)
-        return Loc.Hash < Other.Loc.Hash;
+      if (Var == Other.Var) {
+        if (Other.Kind == Kind)
----------------
aprantl wrote:
> Can you convert this into early-exit form?
> 
> ```
> if (Var != Other.Var)
>   return Var < Other.Var;
> ...
> ```
Sure.


================
Comment at: lib/CodeGen/LiveDebugValues.cpp:454
+  for (unsigned ID : KillSet) {
+    if (VarLocIDs[ID].Var.getVar() &&
+        VarLocIDs[ID].Var.getVar()->isParameter()) {
----------------
aprantl wrote:
> factor out VarLocIDs[ID] (.Var.getVar()) for readability?
Sure.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58042/new/

https://reviews.llvm.org/D58042