[PATCH] D58843: [WIP][MC][RISCV] Allow targets to defer forcing relocations

Tue Apr 23 08:05:04 PDT 2019

bcain requested changes to this revision.
bcain added inline comments.
This revision now requires changes to proceed.

================
Comment at: include/llvm/MC/MCAsmBackend.h:84-85

   /// Hook to check if a relocation is needed for some target specific reason.
-  virtual bool shouldForceRelocation(const MCAssembler &Asm,
-                                     const MCFixup &Fixup,
-                                     const MCValue &Target) {
+  virtual Optional<bool> shouldForceRelocation(const MCAssembler &Asm,
+                                               const MCFixup &Fixup,
----------------
Could you make it explicit in the doc comments here that a returned value of 'None' indicates that it's indeterminate/unknown whether relocation is required.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58843/new/

https://reviews.llvm.org/D58843