[PATCH] D58632: [X86] Improve lowering of idemptotent RMW operations

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 23 22:36:26 PDT 2019


craig.topper added inline comments.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:25984
+
+  // NOTE TO REVIEWERS: Do all x86 calling conventions have a redzone?  I
+  // suspect not, but can't find this property to test again.  (usesRedZone on
----------------
Windows 64 definitely doesn't have a red zone. I'm not sure if any 32-bit target does.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58632/new/

https://reviews.llvm.org/D58632





More information about the llvm-commits mailing list