[PATCH] D60550: [X86] Enable AVX512_BF16 instructions, which are supported for BFLOAT16 in Cooper Lake

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: lib/Target/X86/X86ISelLowering.h:513
+      // Vector float to bfloat16
+      CVTNE2PS2BF16, CVTNEPS2BF16, DPBF16PS,
+
----------------
liutianle wrote:
> RKSimon wrote:
> > Bit more description would be good if possible - those enums look very similar at first glance!
> @RKSimon , I update it. Please review again.
Separate DPBF16PS on to its own line with its own description below MCVTNEPS2BF16


================
Comment at: lib/Target/X86/X86ISelLowering.h:512
 
+      // Vector float to bfloat16. Convert packed single data to packed BF16
+      // data, and dot product of BF16 pairs to single presision.
----------------
Mention the difference between CVTNE2PS2BF16 and CVTNEPS2BF16. i.e. that CVTNE2PS2BF16 compresses two vectors to one.


================
Comment at: lib/Target/X86/X86ISelLowering.h:513
+      // Vector float to bfloat16. Convert packed single data to packed BF16
+      // data, and dot product of BF16 pairs to single presision.
+      CVTNE2PS2BF16, CVTNEPS2BF16, DPBF16PS,
----------------
presision -> precision


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60550/new/

https://reviews.llvm.org/D60550