[PATCH] D58266: [MC] Sort DWARF FDEs by the associated CIE before emitting them.

[Lang Hames via Phabricator via llvm-commits]

lhames added a comment.
Herald added a subscriber: dexonsmith.

Late to the party here, but if the DWARF spec doesn’t require FDEs to refer to the most recent CIE, is it worth making this optional, even if it’s on by default? Otherwise we risk writing code that assumes this sanitized layout when the spec doesn’t guarantee it.

I actually just hit this issue in JITLink: its eh-frame parser used to assume that FDEs referred to the most recent CIE (because of course they would, right?), but then broke on output from older clangs. I relaxed JITLink’s eh-frame parser to support references to any previous CIE, only to discover that I could no longer write a test case now that LLVM unconditionally does the “right” thing. :P


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58266/new/

https://reviews.llvm.org/D58266