[PATCH] D58427: Fix checking for rpc/xdr.h

[Enji Cooper via Phabricator via llvm-commits]

ngie marked 2 inline comments as done.
ngie added inline comments.


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_solaris.cc:31
 #include <pwd.h>
+#include <rpc/types.h>
 #include <rpc/xdr.h>
----------------
MaskRay wrote:
> Are you sure Solaris needs this? This is contrary to my research.
I couldn't find any references, so I removed it.


================
Comment at: compiler-rt/test/msan/Linux/sunrpc.cc:17
 #include <assert.h>
+#include <rpc/types.h>
 #include <rpc/xdr.h>
----------------
MaskRay wrote:
> MaskRay wrote:
> > Does Linux need this?
> See https://github.com/APokorny/libtirpc/blob/master/tirpc/rpc/xdr.h#L46 and /usr/include/rpc/xdr.h (glibc; newer glibc removed sunrpc headers) on a Linux distribution.
No. I'll remove it since it's OS platform specific.


================
Comment at: compiler-rt/test/msan/Linux/sunrpc_bytes.cc:10
 #include <string.h>
+#include <rpc/types.h>
 #include <rpc/xdr.h>
----------------
MaskRay wrote:
> Does Linux need this?
No. I'll remove it since it's OS platform specific.


================
Comment at: compiler-rt/test/msan/Linux/sunrpc_string.cc:10
 #include <string.h>
+#include <rpc/types.h>
 #include <rpc/xdr.h>
----------------
MaskRay wrote:
> Does Linux need this?
No. I'll remove it since it's OS platform specific.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58427/new/

https://reviews.llvm.org/D58427